Skip to content

feat: 为后端的存在做准备#275

Closed
longsizhuo wants to merge 6 commits intobackendfrom
claude/fix-assistant-ui-deps-VUue0
Closed

feat: 为后端的存在做准备#275
longsizhuo wants to merge 6 commits intobackendfrom
claude/fix-assistant-ui-deps-VUue0

Conversation

@longsizhuo
Copy link
Copy Markdown
Member

No description provided.

@assistant-ui/store@0.2.6 and @assistant-ui/core@0.1.13 require
@assistant-ui/tap@^0.5.6, but the lockfile had tap@0.3.6 which
renamed its exports (createResourceContext→createResource, tap→tapRef,
etc.), causing 16 Turbopack build errors.

Added pnpm override to force @assistant-ui/tap@0.5.7 and regenerated
the lockfile.

https://claude.ai/code/session_01YGNupgHxmKvUdpX1x72xjR
Copilot AI review requested due to automatic review settings April 11, 2026 02:31
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
involutionhell-github-io Ready Ready Preview, Comment Apr 11, 2026 5:32am
website-preview Ready Ready Preview, Comment Apr 11, 2026 5:32am

Copy link
Copy Markdown
Member Author

@longsizhuo longsizhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgfm

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dependency resolution to prepare the project’s Assistant UI stack by pinning @assistant-ui/tap to a newer version and regenerating the pnpm lockfile accordingly.

Changes:

  • Add a pnpm.overrides entry to force @assistant-ui/tap to 0.5.7.
  • Update pnpm-lock.yaml to reflect the new @assistant-ui/tap resolution across @assistant-ui/* packages.
  • Regenerate lockfile metadata (notably removing many libc fields for native optional packages).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
package.json Adds a pnpm override to pin @assistant-ui/tap to 0.5.7.
pnpm-lock.yaml Updates lockfile to resolve @assistant-ui/tap to 0.5.7 and includes broad regeneration/format changes.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json Outdated
Comment on lines +119 to +120
"@types/react-dom": "19.2.3",
"@assistant-ui/tap": "0.5.7"
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm.overrides is forcing @assistant-ui/tap to 0.5.7, which can bypass upstream semver constraints for transitive dependencies. Please add a short rationale (e.g., bugfix/vulnerability/compatibility) and confirm that all @assistant-ui/* packages in this repo are compatible with tap@0.5.7 (ideally by upgrading the top-level @assistant-ui/* deps instead of pinning a transitive override, if available).

Suggested change
"@types/react-dom": "19.2.3",
"@assistant-ui/tap": "0.5.7"
"@types/react-dom": "19.2.3"

Copilot uses AI. Check for mistakes.
Comment thread pnpm-lock.yaml
Comment on lines 1440 to 1444
'@img/sharp-libvips-linux-arm64@1.2.4':
resolution: {integrity: sha512-excjX8DfsIcJ10x1Kzr4RcWe1edC9PquDRRPx3YVCvQv+U5p7Yin2s32ftzikXojb1PIFc/9Mt28/y+iRklkrw==}
cpu: [arm64]
os: [linux]
libc: [glibc]

Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lockfile update removes the libc platform constraint metadata from many native optional packages (e.g., sharp/libvips builds). If this churn wasn’t intentional, it usually indicates the lockfile was regenerated with a different pnpm version/config and may cause future reformatting or platform-selection surprises in CI. Please confirm the lockfile was generated using the repo’s pinned pnpm version (packageManager: pnpm@10.20.0) and a clean install, and consider minimizing unrelated lockfile changes if possible.

Copilot uses AI. Check for mistakes.
@assistant-ui/react@0.11.x uses the old tap API (createContext, tapContext etc.)
which conflicts with tap@0.5.7 (new API). Upgrading to 0.12.24 which uses the
new tap API and is compatible with the existing override.

https://claude.ai/code/session_01YGNupgHxmKvUdpX1x72xjR
…/react@0.12.x

attachment.type is now typed as "image" | "document" | "file" | (string & {})
in 0.12.x, so the never exhaustive check fails. Replace with a safe default fallback.

https://claude.ai/code/session_01YGNupgHxmKvUdpX1x72xjR
Now that @assistant-ui/react is upgraded to 0.12.24, which directly
declares @assistant-ui/tap@^0.5.7 as a dependency, the override is
redundant — pnpm resolves to 0.5.7 naturally without it.

Addresses Copilot CR on PR #275.

https://claude.ai/code/session_01YGNupgHxmKvUdpX1x72xjR
1. app/layout.tsx: strip surrounding quotes from NEXT_PUBLIC_SITE_URL
   Environment variable was configured with extra double-quotes
   (e.g. '"https://involutionhell.com"'), causing new URL() to throw
   ERR_INVALID_URL at page-data collection time.

2. lib/source.ts: eagerly resolve fumadocs-mdx lazy files function
   fumadocs-mdx@11.x returns `files` as a lazy function in
   toFumadocsSource(), but fumadocs-core@15.8.x buildContentStorage
   calls files.map() directly expecting an array. Mutate the source
   object before passing to loader() to bridge the incompatibility.

https://claude.ai/code/session_01YGNupgHxmKvUdpX1x72xjR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants